Commit 31b10f2c authored Jul 03, 2020 by Tom Rix Committed by Greg Kroah-Hartman Jul 31, 2020

net: sky2: initialize return of gm_phy_read



[ Upstream commit 28b18e4eb515af7c6661c3995c6e3c34412c2874 ]

clang static analysis flags this garbage return

drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]
        return v;
        ^~~~~~~~

static inline u16 gm_phy_read( ...
{
	u16 v;
	__gm_phy_read(hw, port, reg, &v);
	return v;
}

__gm_phy_read can return without setting v.

So handle similar to skge.c's gm_phy_read, initialize v.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4d565f46

drivers/net/ethernet/marvell/sky2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -215,7 +215,7 @@ static int __gm_phy_read(struct sky2_hw hw, unsigned port, u16 reg, u16 val)

		static inline u16 gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg)
		{
		u16 v;
		u16 v = 0;
		__gm_phy_read(hw, port, reg, &v);
		return v;
		}