Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31670070 authored by Jiri Slaby's avatar Jiri Slaby Committed by John W. Linville
Browse files

ath5k: remove permissions from debugfs files 



Don't allow users to open debugfs files, because it can cause oopses.

When a user opens some file, driver unlinks it and frees the
corresponding structure, we will dereference freed memory.

Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 6badaaf7

drivers/net/wireless/ath/ath5k/debug.c

+5 −3
Original line number Diff line number Diff line
@@ -380,13 +380,15 @@ ath5k_debug_init_device(struct ath5k_softc *sc) 
	sc->debug.debugfs_phydir = debugfs_create_dir(wiphy_name(sc->hw->wiphy),

				ath5k_global_debugfs);



	sc->debug.debugfs_debug = debugfs_create_file("debug", S_IWUSR | S_IRUGO,

	sc->debug.debugfs_debug = debugfs_create_file("debug",

				S_IWUSR | S_IRUSR,

				sc->debug.debugfs_phydir, sc, &fops_debug);



	sc->debug.debugfs_registers = debugfs_create_file("registers", S_IRUGO,

	sc->debug.debugfs_registers = debugfs_create_file("registers", S_IRUSR,

				sc->debug.debugfs_phydir, sc, &fops_registers);



	sc->debug.debugfs_beacon = debugfs_create_file("beacon", S_IWUSR | S_IRUGO,

	sc->debug.debugfs_beacon = debugfs_create_file("beacon",

				S_IWUSR | S_IRUSR,

				sc->debug.debugfs_phydir, sc, &fops_beacon);



	sc->debug.debugfs_reset = debugfs_create_file("reset", S_IWUSR,