Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 312b00e5 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Linus Walleij
Browse files

pinctrl: exynos: don't mark probing functions as __init 



Functions called from a driver probe() method must not be
marked __init, because they may get called after the
init phase is done, when the device shows up late, or
because of deferred probing.

Without this patch, building exynos_defconfig results in
multiple warnings like:

WARNING: drivers/pinctrl/built-in.o(.text+0x51bc): Section mismatch in reference from the function exynos5440_pinctrl_probe() to the function .init.text:exynos5440_gpiolib_register()
The function exynos5440_pinctrl_probe() references
the function __init exynos5440_gpiolib_register().
This is often because exynos5440_pinctrl_probe lacks a __init
annotation or the annotation of exynos5440_gpiolib_register is wrong.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: Tomasz Figa <t.figa@samsung.com>
Acked-by: default avatarKukjin Kim <kgene.kim@samsung.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 8b77b376

drivers/pinctrl/pinctrl-exynos5440.c

+5 −5
Original line number Diff line number Diff line
@@ -599,7 +599,7 @@ static int exynos5440_gpio_direction_output(struct gpio_chip *gc, unsigned offse 
}



/* parse the pin numbers listed in the 'samsung,exynos5440-pins' property */

static int __init exynos5440_pinctrl_parse_dt_pins(struct platform_device *pdev,

static int exynos5440_pinctrl_parse_dt_pins(struct platform_device *pdev,

			struct device_node *cfg_np, unsigned int **pin_list,

			unsigned int *npins)

{
@@ -630,7 +630,7 @@ static int __init exynos5440_pinctrl_parse_dt_pins(struct platform_device *pdev, 
 * Parse the information about all the available pin groups and pin functions

 * from device node of the pin-controller.

 */

static int __init exynos5440_pinctrl_parse_dt(struct platform_device *pdev,

static int exynos5440_pinctrl_parse_dt(struct platform_device *pdev,

				struct exynos5440_pinctrl_priv_data *priv)

{

	struct device *dev = &pdev->dev;
@@ -723,7 +723,7 @@ static int __init exynos5440_pinctrl_parse_dt(struct platform_device *pdev, 
}



/* register the pinctrl interface with the pinctrl subsystem */

static int __init exynos5440_pinctrl_register(struct platform_device *pdev,

static int exynos5440_pinctrl_register(struct platform_device *pdev,

				struct exynos5440_pinctrl_priv_data *priv)

{

	struct device *dev = &pdev->dev;
@@ -798,7 +798,7 @@ static int __init exynos5440_pinctrl_register(struct platform_device *pdev, 
}



/* register the gpiolib interface with the gpiolib subsystem */

static int __init exynos5440_gpiolib_register(struct platform_device *pdev,

static int exynos5440_gpiolib_register(struct platform_device *pdev,

				struct exynos5440_pinctrl_priv_data *priv)

{

	struct gpio_chip *gc;
@@ -831,7 +831,7 @@ static int __init exynos5440_gpiolib_register(struct platform_device *pdev, 
}



/* unregister the gpiolib interface with the gpiolib subsystem */

static int __init exynos5440_gpiolib_unregister(struct platform_device *pdev,

static int exynos5440_gpiolib_unregister(struct platform_device *pdev,

				struct exynos5440_pinctrl_priv_data *priv)

{

	int ret = gpiochip_remove(priv->gc);