Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 311d7eb5 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Greg Kroah-Hartman
Browse files

dmaengine: at_xdmac: fix AT_XDMAC_CC_PERID() macro 



[ Upstream commit 320c88a3104dc955f928a1eecebd551ff89530c0 ]

AT_XDMAC_CC_PERID() should be used to setup bits 24..30 of XDMAC_CC
register. Using it without parenthesis around 0x7f & (i) will lead to
setting all the time zero for bits 24..30 of XDMAC_CC as the << operator
has higher precedence over bitwise &. Thus, add paranthesis around
0x7f & (i).

Fixes: 15a03850 ("dmaengine: at_xdmac: fix macro typo")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20211007111230.2331837-3-claudiu.beznea@microchip.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 941c42fc

drivers/dma/at_xdmac.c

+1 −1
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ 
#define		AT_XDMAC_CC_WRIP	(0x1 << 23)	/* Write in Progress (read only) */

#define			AT_XDMAC_CC_WRIP_DONE		(0x0 << 23)

#define			AT_XDMAC_CC_WRIP_IN_PROGRESS	(0x1 << 23)

#define		AT_XDMAC_CC_PERID(i)	(0x7f & (i) << 24)	/* Channel Peripheral Identifier */

#define		AT_XDMAC_CC_PERID(i)	((0x7f & (i)) << 24)	/* Channel Peripheral Identifier */

#define AT_XDMAC_CDS_MSP	0x2C	/* Channel Data Stride Memory Set Pattern */

#define AT_XDMAC_CSUS		0x30	/* Channel Source Microblock Stride */

#define AT_XDMAC_CDUS		0x34	/* Channel Destination Microblock Stride */