Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30a4bb1e authored by Allen Hubbe's avatar Allen Hubbe Committed by Jon Mason
Browse files

NTB: Fix dereference before check 



Remove early dereference of a pointer that is checked later in the code.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAllen Hubbe <Allen.Hubbe@emc.com>
Signed-off-by: default avatarJon Mason <jdmason@kudzu.us>
parent 8c9edf63

drivers/ntb/ntb_transport.c

+1 −2
Original line number Diff line number Diff line
@@ -1692,7 +1692,6 @@ EXPORT_SYMBOL_GPL(ntb_transport_create_queue); 
 */

void ntb_transport_free_queue(struct ntb_transport_qp *qp)

{

	struct ntb_transport_ctx *nt = qp->transport;

	struct pci_dev *pdev;

	struct ntb_queue_entry *entry;

	u64 qp_bit;
@@ -1745,7 +1744,7 @@ void ntb_transport_free_queue(struct ntb_transport_qp *qp) 
	while ((entry = ntb_list_rm(&qp->ntb_tx_free_q_lock, &qp->tx_free_q)))

		kfree(entry);



	nt->qp_bitmap_free |= qp_bit;

	qp->transport->qp_bitmap_free |= qp_bit;



	dev_info(&pdev->dev, "NTB Transport QP %d freed\n", qp->qp_num);

}