Commit 2f9dff3f authored Feb 01, 2014 by Antti Palosaari Committed by Mauro Carvalho Chehab Mar 12, 2014

[media] m88ds3103: possible uninitialized scalar variable



It was possible that tuner_frequency variable, used for carrier offset
compensation, was uninitialized. That happens when tuner
.get_frequency() callback is not defined.

Currently that case is not possible as only used tuner has this callback.

Coverity CID 1166057: Uninitialized scalar variable (UNINIT)

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent 8a648fbb

drivers/media/dvb-frontends/m88ds3103.c

+7 −0

Original line number	Original line	Diff line number	Diff line
	@@ -271,6 +271,13 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe)
	ret = fe->ops.tuner_ops.get_frequency(fe, &tuner_frequency);		ret = fe->ops.tuner_ops.get_frequency(fe, &tuner_frequency);
	if (ret)		if (ret)
	goto err;		goto err;
			} else {
			/*
			* Use nominal target frequency as tuner driver does not provide
			* actual frequency used. Carrier offset calculation is not
			* valid.
			*/
			tuner_frequency = c->frequency;
	}		}

	/* reset */		/* reset */