Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f599714 authored by Marcelo Tosatti's avatar Marcelo Tosatti Committed by Avi Kivity
Browse files

KVM: migrate PIT timer 



Migrate the PIT timer to the physical CPU which vcpu0 is scheduled on,
similarly to what is done for the LAPIC timers, otherwise PIT interrupts
will be delayed until an unrelated event causes an exit.

Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: default avatarAvi Kivity <avi@qumranet.com>
parent 9dcb40e1

arch/x86/kvm/i8254.c

+13 −1
Original line number Diff line number Diff line
@@ -200,7 +200,6 @@ int __pit_timer_fn(struct kvm_kpit_state *ps) 


	atomic_inc(&pt->pending);

	smp_mb__after_atomic_inc();

	/* FIXME: handle case where the guest is in guest mode */

	if (vcpu0 && waitqueue_active(&vcpu0->wq)) {

		vcpu0->arch.mp_state = KVM_MP_STATE_RUNNABLE;

		wake_up_interruptible(&vcpu0->wq);
@@ -237,6 +236,19 @@ static enum hrtimer_restart pit_timer_fn(struct hrtimer *data) 
		return HRTIMER_NORESTART;

}



void __kvm_migrate_pit_timer(struct kvm_vcpu *vcpu)

{

	struct kvm_pit *pit = vcpu->kvm->arch.vpit;

	struct hrtimer *timer;



	if (vcpu->vcpu_id != 0 || !pit)

		return;



	timer = &pit->pit_state.pit_timer.timer;

	if (hrtimer_cancel(timer))

		hrtimer_start(timer, timer->expires, HRTIMER_MODE_ABS);

}



static void destroy_pit_timer(struct kvm_kpit_timer *pt)

{

	pr_debug("pit: execute del timer!\n");

arch/x86/kvm/irq.c

+6 −0
Original line number Diff line number Diff line
@@ -94,3 +94,9 @@ void kvm_timer_intr_post(struct kvm_vcpu *vcpu, int vec) 
	/* TODO: PIT, RTC etc. */

}

EXPORT_SYMBOL_GPL(kvm_timer_intr_post);



void __kvm_migrate_timers(struct kvm_vcpu *vcpu)

{

	__kvm_migrate_apic_timer(vcpu);

	__kvm_migrate_pit_timer(vcpu);

}

arch/x86/kvm/irq.h

+2 −0
Original line number Diff line number Diff line
@@ -84,6 +84,8 @@ void kvm_timer_intr_post(struct kvm_vcpu *vcpu, int vec); 
void kvm_inject_pending_timer_irqs(struct kvm_vcpu *vcpu);

void kvm_inject_apic_timer_irqs(struct kvm_vcpu *vcpu);

void __kvm_migrate_apic_timer(struct kvm_vcpu *vcpu);

void __kvm_migrate_pit_timer(struct kvm_vcpu *vcpu);

void __kvm_migrate_timers(struct kvm_vcpu *vcpu);



int pit_has_pending_timer(struct kvm_vcpu *vcpu);

int apic_has_pending_timer(struct kvm_vcpu *vcpu);

arch/x86/kvm/svm.c

+1 −1
Original line number Diff line number Diff line
@@ -688,7 +688,7 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu) 
		delta = vcpu->arch.host_tsc - tsc_this;

		svm->vmcb->control.tsc_offset += delta;

		vcpu->cpu = cpu;

		kvm_migrate_apic_timer(vcpu);

		kvm_migrate_timers(vcpu);

	}



	for (i = 0; i < NR_HOST_SAVE_USER_MSRS; i++)

arch/x86/kvm/vmx.c

+1 −1
Original line number Diff line number Diff line
@@ -608,7 +608,7 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) 


	if (vcpu->cpu != cpu) {

		vcpu_clear(vmx);

		kvm_migrate_apic_timer(vcpu);

		kvm_migrate_timers(vcpu);

		vpid_sync_vcpu_all(vmx);

	}