Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e9e8bc3 authored by Roland Dreier's avatar Roland Dreier Committed by Greg Kroah-Hartman
Browse files

CDC-NCM: remove "connected" log message 



[ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ]

The cdc_ncm driver passes network connection notifications up to
usbnet_link_change(), which is the right place for any logging.
Remove the netdev_info() duplicating this from the driver itself.

This stops devices such as my "TRENDnet USB 10/100/1G/2.5G LAN"
(ID 20f4:e02b) adapter from spamming the kernel log with

    cdc_ncm 2-2:2.0 enp0s2u2c2: network connection: connected

messages every 60 msec or so.

Signed-off-by: default avatarRoland Dreier <roland@kernel.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20201224032116.2453938-1-roland@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 09d88553

drivers/net/usb/cdc_ncm.c

+0 −3
Original line number Diff line number Diff line
@@ -1602,9 +1602,6 @@ static void cdc_ncm_status(struct usbnet *dev, struct urb *urb) 
		 * USB_CDC_NOTIFY_NETWORK_CONNECTION notification shall be

		 * sent by device after USB_CDC_NOTIFY_SPEED_CHANGE.

		 */

		netif_info(dev, link, dev->net,

			   "network connection: %sconnected\n",

			   !!event->wValue ? "" : "dis");

		usbnet_link_change(dev, !!event->wValue, 0);

		break;