Commit 2e7486a0 authored Mar 13, 2017 by Johan Hovold Committed by Greg Kroah-Hartman Mar 30, 2017

uwb: hwa-rc: fix NULL-deref at probe



commit daf229b15907fbfdb6ee183aac8ca428cb57e361 upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Note that the dereference happens in the start callback which is called
during probe.

Fixes: de520b8b ("uwb: add HWA radio controller driver")
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: David Vrabel <david.vrabel@csr.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f01c54fe

drivers/uwb/hwa-rc.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -823,6 +823,9 @@ static int hwarc_probe(struct usb_interface *iface,
		struct hwarc *hwarc;
		struct device *dev = &iface->dev;

		if (iface->cur_altsetting->desc.bNumEndpoints < 1)
		return -ENODEV;

		result = -ENOMEM;
		uwb_rc = uwb_rc_alloc();
		if (uwb_rc == NULL) {