Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e0965b0 authored by Jyri Sarha's avatar Jyri Sarha
Browse files

drm/tilcdc: WARN if CRTC is touched without CRTC lock 



WARN if CRTC is touched without CRTC lock. The crtc functions should
not be called simultaneously from multiple threads. Having the DRM
CRTC lock should take care of that.

Signed-off-by: default avatarJyri Sarha <jsarha@ti.com>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 6c94c714

drivers/gpu/drm/tilcdc/tilcdc_crtc.c

+8 −0
Original line number Diff line number Diff line
@@ -153,6 +153,8 @@ static void tilcdc_crtc_enable(struct drm_crtc *crtc) 
	struct drm_device *dev = crtc->dev;

	struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc);



	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));



	if (tilcdc_crtc->enabled)

		return;
@@ -177,6 +179,8 @@ void tilcdc_crtc_disable(struct drm_crtc *crtc) 
	struct drm_device *dev = crtc->dev;

	struct tilcdc_drm_private *priv = dev->dev_private;



	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));



	if (!tilcdc_crtc->enabled)

		return;
@@ -249,6 +253,8 @@ int tilcdc_crtc_update_fb(struct drm_crtc *crtc, 
	struct drm_device *dev = crtc->dev;

	unsigned long flags;



	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));



	if (tilcdc_crtc->event) {

		dev_err(dev->dev, "already pending page flip!\n");

		return -EBUSY;
@@ -353,6 +359,8 @@ static void tilcdc_crtc_mode_set_nofb(struct drm_crtc *crtc) 
	struct drm_display_mode *mode = &crtc->state->adjusted_mode;

	struct drm_framebuffer *fb = crtc->primary->state->fb;



	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));



	if (WARN_ON(!info))

		return;