Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2dc2a15e authored by Johannes Berg's avatar Johannes Berg Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: LRU-assign key offsets 



The current key offset assignment algorithm always uses the lowest
unused key offset, which will potentially lead to issues when the
firmware will change to take the key material for TX from the key
table rather than from the TX command.

In order to avoid those issues (and avoid forgetting about them)
change the key offset allocation algorithm now to avoid reusing key
offsets quickly.

The new algorithm always picks as the next offset the least recently
freed offset, i.e. the offset that has been unused for the longest
amount of time. This is implemented by having a generation counter
for each key offset that is incremented every time a key is deleted,
except for the one that's deleted, which is reset to zero. Thus the
highest counter is the key that's been unused longest.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 94ce9e5e

drivers/net/wireless/iwlwifi/mvm/mvm.h

+1 −0
Original line number Diff line number Diff line
@@ -686,6 +686,7 @@ struct iwl_mvm { 
	 * can hold 16 keys at most. Reflect this fact.

	 */

	unsigned long fw_key_table[BITS_TO_LONGS(STA_KEY_MAX_NUM)];

	u8 fw_key_deleted[STA_KEY_MAX_NUM];



	/* references taken by the driver and spinlock protecting them */

	spinlock_t refs_lock;

drivers/net/wireless/iwlwifi/mvm/sta.c

+26 −6
Original line number Diff line number Diff line
@@ -1148,18 +1148,31 @@ int iwl_mvm_sta_tx_agg_flush(struct iwl_mvm *mvm, struct ieee80211_vif *vif, 


static int iwl_mvm_set_fw_key_idx(struct iwl_mvm *mvm)

{

	int i;

	int i, max = -1, max_offs = -1;



	lockdep_assert_held(&mvm->mutex);



	i = find_first_zero_bit(mvm->fw_key_table, STA_KEY_MAX_NUM);

	/* Pick the unused key offset with the highest 'deleted'

	 * counter. Every time a key is deleted, all the counters

	 * are incremented and the one that was just deleted is

	 * reset to zero. Thus, the highest counter is the one

	 * that was deleted longest ago. Pick that one.

	 */

	for (i = 0; i < STA_KEY_MAX_NUM; i++) {

		if (test_bit(i, mvm->fw_key_table))

			continue;

		if (mvm->fw_key_deleted[i] > max) {

			max = mvm->fw_key_deleted[i];

			max_offs = i;

		}

	}



	if (i == STA_KEY_MAX_NUM)

	if (max_offs < 0)

		return STA_KEY_IDX_INVALID;



	__set_bit(i, mvm->fw_key_table);

	__set_bit(max_offs, mvm->fw_key_table);



	return i;

	return max_offs;

}



static u8 iwl_mvm_get_key_sta_id(struct ieee80211_vif *vif,
@@ -1478,7 +1491,7 @@ int iwl_mvm_remove_sta_key(struct iwl_mvm *mvm, 
{

	bool mcast = !(keyconf->flags & IEEE80211_KEY_FLAG_PAIRWISE);

	u8 sta_id;

	int ret;

	int ret, i;



	lockdep_assert_held(&mvm->mutex);
@@ -1497,6 +1510,13 @@ int iwl_mvm_remove_sta_key(struct iwl_mvm *mvm, 
		return -ENOENT;

	}



	/* track which key was deleted last */

	for (i = 0; i < STA_KEY_MAX_NUM; i++) {

		if (mvm->fw_key_deleted[i] < U8_MAX)

			mvm->fw_key_deleted[i]++;

	}

	mvm->fw_key_deleted[keyconf->hw_key_idx] = 0;



	if (sta_id == IWL_MVM_STATION_COUNT) {

		IWL_DEBUG_WEP(mvm, "station non-existent, early return.\n");

		return 0;