Commit 2d7e4e83 authored Jul 25, 2017 by Subhash Jadavani

scsi: ufs: fix unclocked register access during UFS card detection



UFS card detect function (ufshcd_card_detect_handler()) holds the runtime
PM reference during UFS card detection and releases the reference on exit.
But ufshcd_probe_hba() (which is indirectly called during card detection)
also releases the runtime PM reference. If we do multiple card
insertion-removal, this may lead to runtime suspend getting triggered while
we are in the middle of card detection phase.
Fix this by not releasing the runtime PM reference again in UFS card detect
function.

Change-Id: Ia779b2ece6440d230d5dec5e8f0144462e048b2d
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>

parent 814e5c69

drivers/scsi/ufs/ufshcd.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -7862,7 +7862,7 @@ static void ufshcd_card_detect_handler(struct work_struct *work)
	__func__);		__func__);
	pm_runtime_get_sync(hba->dev);		pm_runtime_get_sync(hba->dev);
	ufshcd_detect_device(hba);		ufshcd_detect_device(hba);
	pm_runtime_put_sync(hba->dev);		/* ufshcd_probe_hba() calls pm_runtime_put_sync() on exit */
	} else {		} else {
	dev_dbg(hba->dev, "%s: card removed notification received\n",		dev_dbg(hba->dev, "%s: card removed notification received\n",
	__func__);		__func__);