Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c9bcece authored by Manikanta Pubbisetty's avatar Manikanta Pubbisetty Committed by Kalle Valo
Browse files

ath10k: consolidate if statements in ath10k_wmi_event_mgmt_rx 



This patch replaces multiple if conditional checks with a single if condition
in WMI management rx handler. Found during code review.

Signed-off-by: default avatarManikanta Pubbisetty <manikanta.pubbisetty@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 13eff531

drivers/net/wireless/ath/ath10k/wmi.c

+3 −16
Original line number Diff line number Diff line
@@ -2204,22 +2204,9 @@ int ath10k_wmi_event_mgmt_rx(struct ath10k *ar, struct sk_buff *skb) 
	ath10k_dbg(ar, ATH10K_DBG_MGMT,

		   "event mgmt rx status %08x\n", rx_status);



	if (test_bit(ATH10K_CAC_RUNNING, &ar->dev_flags)) {

		dev_kfree_skb(skb);

		return 0;

	}



	if (rx_status & WMI_RX_STATUS_ERR_DECRYPT) {

		dev_kfree_skb(skb);

		return 0;

	}



	if (rx_status & WMI_RX_STATUS_ERR_KEY_CACHE_MISS) {

		dev_kfree_skb(skb);

		return 0;

	}



	if (rx_status & WMI_RX_STATUS_ERR_CRC) {

	if ((test_bit(ATH10K_CAC_RUNNING, &ar->dev_flags)) ||

	    (rx_status & (WMI_RX_STATUS_ERR_DECRYPT |

	    WMI_RX_STATUS_ERR_KEY_CACHE_MISS | WMI_RX_STATUS_ERR_CRC))) {

		dev_kfree_skb(skb);

		return 0;

	}