Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bfeeca1 authored by Martin Kepplinger's avatar Martin Kepplinger Committed by Greg Kroah-Hartman
Browse files

fbdev: pxa3xx-gcu: remove redundant implementation of open() 



the miscdevice core now does the work in any case.

Signed-off-by: default avatarMartin Kepplinger <martink@posteo.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32eca221

drivers/video/fbdev/pxa3xx-gcu.c

+0 −10
Original line number Diff line number Diff line
@@ -373,15 +373,6 @@ static inline struct pxa3xx_gcu_priv *to_pxa3xx_gcu_priv(struct file *file) 
	return container_of(dev, struct pxa3xx_gcu_priv, misc_dev);

}



/*

 * provide an empty .open callback, so the core sets file->private_data

 * for us.

 */

static int pxa3xx_gcu_open(struct inode *inode, struct file *file)

{

	return 0;

}



static ssize_t

pxa3xx_gcu_write(struct file *file, const char *buff,

		 size_t count, loff_t *offp)
@@ -580,7 +571,6 @@ pxa3xx_gcu_free_buffers(struct device *dev, 


static const struct file_operations pxa3xx_gcu_miscdev_fops = {

	.owner =		THIS_MODULE,

	.open =			pxa3xx_gcu_open,

	.write =		pxa3xx_gcu_write,

	.unlocked_ioctl =	pxa3xx_gcu_ioctl,

	.mmap =			pxa3xx_gcu_mmap,