Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b600f95 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf symbols: Get rid of duplicated snprintf() 

The 'path' variable is set on a upper line, don't need to do it again.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1323703017-6060-3-git-send-email-namhyung@gmail.com


Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 301b195d

tools/perf/util/symbol.c

+1 −6
Original line number Diff line number Diff line
@@ -1757,7 +1757,7 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg, 
		struct stat st;



		/*sshfs might return bad dent->d_type, so we have to stat*/

		sprintf(path, "%s/%s", dir_name, dent->d_name);

		snprintf(path, sizeof(path), "%s/%s", dir_name, dent->d_name);

		if (stat(path, &st))

			continue;
@@ -1766,8 +1766,6 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg, 
			    !strcmp(dent->d_name, ".."))

				continue;



			snprintf(path, sizeof(path), "%s/%s",

				 dir_name, dent->d_name);

			ret = map_groups__set_modules_path_dir(mg, path);

			if (ret < 0)

				goto out;
@@ -1788,9 +1786,6 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg, 
			if (map == NULL)

				continue;



			snprintf(path, sizeof(path), "%s/%s",

				 dir_name, dent->d_name);



			long_name = strdup(path);

			if (long_name == NULL) {

				ret = -1;