Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a584051 authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman
Browse files

Input: goodix - disable IRQs while suspended 


[ Upstream commit faec44b6838312484d63e82286087cf2d5ebb891 ]

We should not try to do any i2c transfers before the controller is
resumed (which happens before our resume method gets called).

So we need to disable our IRQ while suspended to enforce this. The
code paths for devices with GPIOs for the int and reset pins already
disable the IRQ the through goodix_free_irq().

This commit also disables the IRQ while suspended for devices without
GPIOs for the int and reset pins.

This fixes the i2c bus sometimes getting stuck after a suspend/resume
causing the touchscreen to sometimes not work after a suspend/resume.
This has been tested on a GPD pocked device.

BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://www.reddit.com/r/GPDPocket/comments/7niut2/fix_for_broken_touch_after_resume_all_linux/


Tested-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarBastien Nocera <hadess@hadess.net>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 905348d0

drivers/input/touchscreen/goodix.c

+6 −2
Original line number Diff line number Diff line
@@ -778,8 +778,10 @@ static int __maybe_unused goodix_suspend(struct device *dev) 
	int error;



	/* We need gpio pins to suspend/resume */

	if (!ts->gpiod_int || !ts->gpiod_rst)

	if (!ts->gpiod_int || !ts->gpiod_rst) {

		disable_irq(client->irq);

		return 0;

	}



	wait_for_completion(&ts->firmware_loading_complete);
@@ -819,8 +821,10 @@ static int __maybe_unused goodix_resume(struct device *dev) 
	struct goodix_ts_data *ts = i2c_get_clientdata(client);

	int error;



	if (!ts->gpiod_int || !ts->gpiod_rst)

	if (!ts->gpiod_int || !ts->gpiod_rst) {

		enable_irq(client->irq);

		return 0;

	}



	/*

	 * Exit sleep mode by outputting HIGH level to INT pin