Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 298a41ca authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

[PATCH] libata: cosmetic changes in ata_bus_softreset() 



ata_bus_softreset() should return AC_ERR_* on failure not arbitrary
positive number.  While at it, reformat comment above it.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent aec5c3c1

drivers/scsi/libata-core.c

+4 −5
Original line number Diff line number Diff line
@@ -2008,13 +2008,12 @@ static unsigned int ata_bus_softreset(struct ata_port *ap, 
	 */

	msleep(150);





	/* Before we perform post reset processing we want to see if

	   the bus shows 0xFF because the odd clown forgets the D7 pulldown

	   resistor */



	 * the bus shows 0xFF because the odd clown forgets the D7

	 * pulldown resistor.

	 */

	if (ata_check_status(ap) == 0xFF)

		return 1;	/* Positive is failure for some reason */

		return AC_ERR_OTHER;



	ata_bus_post_reset(ap, devmask);