Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 281a8273 authored by Oleg Drokin's avatar Oleg Drokin Committed by Greg Kroah-Hartman
Browse files

staging/lustre/libcfs: Do not call kthread_run in wrong state 



kthread_run might sleep during an allocation, and so
it's considered unsafe to call with a state that's not
RUNNABLE.
Move the state setting to after kthread_run call.

Signed-off-by: default avatarOleg Drokin <green@linuxhacker.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 025fd3c2

drivers/staging/lustre/lnet/libcfs/debug.c

+1 −1
Original line number Diff line number Diff line
@@ -362,12 +362,12 @@ void libcfs_debug_dumplog(void) 
	 * get to schedule()

	 */

	init_waitqueue_entry(&wait, current);

	set_current_state(TASK_INTERRUPTIBLE);

	add_wait_queue(&debug_ctlwq, &wait);



	dumper = kthread_run(libcfs_debug_dumplog_thread,

			     (void *)(long)current_pid(),

			     "libcfs_debug_dumper");

	set_current_state(TASK_INTERRUPTIBLE);

	if (IS_ERR(dumper))

		pr_err("LustreError: cannot start log dump thread: %ld\n",

		       PTR_ERR(dumper));