Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 280fce1e authored by Hadar Hen Zion's avatar Hadar Hen Zion Committed by David S. Miller
Browse files

net/mlx4_en: Block insertion of ethtool steering rules while the interface is down 



Attaching steering rules while the interface is down is an invalid operation, block it.

Signed-off-by: default avatarHadar Hen Zion <hadarh@mellanox.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8258bd27

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -1006,7 +1006,8 @@ static int mlx4_en_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd, 
	if ((cmd->cmd == ETHTOOL_GRXCLSRLCNT ||

	if ((cmd->cmd == ETHTOOL_GRXCLSRLCNT ||

	     cmd->cmd == ETHTOOL_GRXCLSRULE ||

	     cmd->cmd == ETHTOOL_GRXCLSRULE ||

	     cmd->cmd == ETHTOOL_GRXCLSRLALL) &&

	     cmd->cmd == ETHTOOL_GRXCLSRLALL) &&

	    mdev->dev->caps.steering_mode != MLX4_STEERING_MODE_DEVICE_MANAGED)

	    (mdev->dev->caps.steering_mode !=

	     MLX4_STEERING_MODE_DEVICE_MANAGED || !priv->port_up))

		return -EINVAL;

		return -EINVAL;





	switch (cmd->cmd) {

	switch (cmd->cmd) {
@@ -1042,7 +1043,8 @@ static int mlx4_en_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd) 
	struct mlx4_en_priv *priv = netdev_priv(dev);

	struct mlx4_en_priv *priv = netdev_priv(dev);

	struct mlx4_en_dev *mdev = priv->mdev;

	struct mlx4_en_dev *mdev = priv->mdev;





	if (mdev->dev->caps.steering_mode != MLX4_STEERING_MODE_DEVICE_MANAGED)

	if (mdev->dev->caps.steering_mode !=

	    MLX4_STEERING_MODE_DEVICE_MANAGED || !priv->port_up)

		return -EINVAL;

		return -EINVAL;





	switch (cmd->cmd) {

	switch (cmd->cmd) {