Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 275e6991 authored by Jorge Lopez's avatar Jorge Lopez Committed by Greg Kroah-Hartman
Browse files

platform/x86: hp_wmi: Fix rfkill causing soft blocked wifi 



commit 1598bfa8e1faa932de42e1ee7628a1c4c4263f0a upstream.

After upgrading BIOS to U82 01.02.01 Rev.A, the console is flooded
strange char "^@" which printed out every second and makes login
nearly impossible. Also the below messages were shown both in console
and journal/dmesg every second:

usb 1-3: Device not responding to setup address.
usb 1-3: device not accepting address 4, error -71
usb 1-3: device descriptor read/all, error -71
usb usb1-port3: unable to enumerate USB device

Wifi is soft blocked by checking rfkill. When unblocked manually,
after few seconds it would be soft blocked again. So I was suspecting
something triggered rfkill to soft block wifi.  At the end it was
fixed by removing hp_wmi module.

The root cause is the way hp-wmi driver handles command 1B on
post-2009 BIOS.  In pre-2009 BIOS, command 1Bh return 0x4 to indicate
that BIOS no longer controls the power for the wireless devices.

Signed-off-by: default avatarJorge Lopez <jorge.lopez2@hp.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216468


Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20221028155527.7724-1-jorge.lopez2@hp.com


Cc: stable@vger.kernel.org
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3c89ca6d

drivers/platform/x86/hp-wmi.c

+10 −2
Original line number Diff line number Diff line
@@ -899,8 +899,16 @@ static int __init hp_wmi_bios_setup(struct platform_device *device) 
	wwan_rfkill = NULL;

	rfkill2_count = 0;



	/*

	 * In pre-2009 BIOS, command 1Bh return 0x4 to indicate that

	 * BIOS no longer controls the power for the wireless

	 * devices. All features supported by this command will no

	 * longer be supported.

	 */

	if (!hp_wmi_bios_2009_later()) {

		if (hp_wmi_rfkill_setup(device))

			hp_wmi_rfkill2_setup(device);

	}



	err = device_create_file(&device->dev, &dev_attr_display);

	if (err)