Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 273e0304 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Alexandre Belloni
Browse files

rtc: ds1305: clean up ds1305_nvram_read()/ds1305_nvram_write() 



The change removes redundant sysfs binary file boundary checks, since
this task is already done on caller size in fs/sysfs/file.c

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent a3781639

drivers/rtc/rtc-ds1305.c

+0 −18
Original line number Diff line number Diff line
@@ -538,15 +538,6 @@ ds1305_nvram_read(struct file *filp, struct kobject *kobj, 


	spi = container_of(kobj, struct spi_device, dev.kobj);



	if (unlikely(off >= DS1305_NVRAM_LEN))

		return 0;

	if (count >= DS1305_NVRAM_LEN)

		count = DS1305_NVRAM_LEN;

	if ((off + count) > DS1305_NVRAM_LEN)

		count = DS1305_NVRAM_LEN - off;

	if (unlikely(!count))

		return count;



	addr = DS1305_NVRAM + off;

	msg_init(&m, x, &addr, count, NULL, buf);
@@ -569,15 +560,6 @@ ds1305_nvram_write(struct file *filp, struct kobject *kobj, 


	spi = container_of(kobj, struct spi_device, dev.kobj);



	if (unlikely(off >= DS1305_NVRAM_LEN))

		return -EFBIG;

	if (count >= DS1305_NVRAM_LEN)

		count = DS1305_NVRAM_LEN;

	if ((off + count) > DS1305_NVRAM_LEN)

		count = DS1305_NVRAM_LEN - off;

	if (unlikely(!count))

		return count;



	addr = (DS1305_WRITE | DS1305_NVRAM) + off;

	msg_init(&m, x, &addr, count, buf, NULL);