Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26e15e87 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

mmc: vub3000: fix control-request direction 



commit 3c0bb3107703d2c58f7a0a7a2060bb57bc120326 upstream.

The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.

Fix the SET_ROM_WAIT_STATES request which erroneously used
usb_rcvctrlpipe().

Fixes: 88095e7b ("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver")
Cc: stable@vger.kernel.org      # 3.0
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210521133026.17296-1-johan@kernel.org


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 454f7b43

drivers/mmc/host/vub300.c

+1 −1
Original line number Diff line number Diff line
@@ -2292,7 +2292,7 @@ static int vub300_probe(struct usb_interface *interface, 
	if (retval < 0)

		goto error5;

	retval =

		usb_control_msg(vub300->udev, usb_rcvctrlpipe(vub300->udev, 0),

		usb_control_msg(vub300->udev, usb_sndctrlpipe(vub300->udev, 0),

				SET_ROM_WAIT_STATES,

				USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,

				firmware_rom_wait_states, 0x0000, NULL, 0, HZ);