Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26b9b156 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Greg Kroah-Hartman
Browse files

ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type 



commit dfb00a56935186171abb5280b3407c3f910011f1 upstream.

An abstraction of asynchronous transaction for transmission of MIDI
messages was introduced in Linux v4.4. Each driver can utilize this
abstraction to transfer MIDI messages via fixed-length payload of
transaction to a certain unit address. Filling payload of the transaction
is done by callback. In this callback, each driver can return negative
error code, however current implementation assigns the return value to
unsigned variable.

This commit changes type of the variable to fix the bug.

Reported-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Fixes: 585d7cba ("ALSA: firewire-lib: add helper functions for asynchronous transactions to transfer MIDI messages")
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 827faa2e

sound/firewire/lib.h

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ struct snd_fw_async_midi_port { 


	struct snd_rawmidi_substream *substream;

	snd_fw_async_midi_port_fill fill;

	unsigned int consume_bytes;

	int consume_bytes;

};



int snd_fw_async_midi_port_init(struct snd_fw_async_midi_port *port,