Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 269b2619 authored by Julia Lawall's avatar Julia Lawall Committed by Linus Torvalds
Browse files

fs/ext3: use BUG_ON

if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@ disable unlikely @ expression E,f; @@

(
  if (<... f(...) ...>) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)

@@ expression E,f; @@

(
  if (<... f(...) ...>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 33575f8f
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -232,8 +232,7 @@ static void __rsv_window_dump(struct rb_root *root, int verbose,
		prev = rsv;
	}
	printk("Window map complete.\n");
	if (bad)
		BUG();
	BUG_ON(bad);
}
#define rsv_window_dump(root, verbose) \
	__rsv_window_dump((root), (verbose), __FUNCTION__)