Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2676c258 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] mt2060: remove fake implementaion of get_bandwidth() 



This driver implements a fake get_bandwidth() callback. In
reallity, the tuner driver won't adjust its low-pass
filter based on a bandwidth, and were just providing a fake
method for demods to read whatever was "set".

This code is useless, as none of the drivers that use
this tuner seems to require a get_bandwidth() callback.

While here, convert set_params to use the DVBv5 way to pass
parameters to tuners.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 8b80ff3a

drivers/media/common/tuners/mt2060.c

+2 −10
Original line number Diff line number Diff line
@@ -155,6 +155,7 @@ static int mt2060_spurcheck(u32 lo1,u32 lo2,u32 if2) 


static int mt2060_set_params(struct dvb_frontend *fe, struct dvb_frontend_parameters *params)

{

	struct dtv_frontend_properties *c = &fe->dtv_property_cache;

	struct mt2060_priv *priv;

	int ret=0;

	int i=0;
@@ -176,8 +177,7 @@ static int mt2060_set_params(struct dvb_frontend *fe, struct dvb_frontend_parame 


	mt2060_writeregs(priv,b,2);



	freq = params->frequency / 1000; // Hz -> kHz

	priv->bandwidth = (fe->ops.info.type == FE_OFDM) ? params->u.ofdm.bandwidth : 0;

	freq = c->frequency / 1000; /* Hz -> kHz */



	f_lo1 = freq + if1 * 1000;

	f_lo1 = (f_lo1 / 250) * 250;
@@ -293,13 +293,6 @@ static int mt2060_get_frequency(struct dvb_frontend *fe, u32 *frequency) 
	return 0;

}



static int mt2060_get_bandwidth(struct dvb_frontend *fe, u32 *bandwidth)

{

	struct mt2060_priv *priv = fe->tuner_priv;

	*bandwidth = priv->bandwidth;

	return 0;

}



static int mt2060_get_if_frequency(struct dvb_frontend *fe, u32 *frequency)

{

	*frequency = IF2 * 1000;
@@ -362,7 +355,6 @@ static const struct dvb_tuner_ops mt2060_tuner_ops = { 


	.set_params    = mt2060_set_params,

	.get_frequency = mt2060_get_frequency,

	.get_bandwidth = mt2060_get_bandwidth,

	.get_if_frequency = mt2060_get_if_frequency,

};

drivers/media/common/tuners/mt2060_priv.h

+0 −1
Original line number Diff line number Diff line
@@ -97,7 +97,6 @@ struct mt2060_priv { 
	struct i2c_adapter   *i2c;



	u32 frequency;

	u32 bandwidth;

	u16 if1_freq;

	u8  fmfreq;

};