Commit 256f3ee3 authored Jun 29, 2016 by Thierry Escande Committed by Samuel Ortiz Jul 06, 2016

NFC: llcp: Fix 2 memory leaks



Once copied into the sk_buff data area using llcp_add_tlv(), the
allocated TLVs must be freed.

With this patch nfc_llcp_send_connect() and nfc_llcp_send_cc() don't
return immediately on success and now free the allocated TLVs.

Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent de9e5aeb

net/nfc/llcp_commands.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -444,9 +444,10 @@ int nfc_llcp_send_connect(struct nfc_llcp_sock *sock)

		skb_queue_tail(&local->tx_queue, skb);

		return 0;
		err = 0;

		error_tlv:
		if (err)
		pr_err("error %d\n", err);

		kfree(service_name_tlv);
		@@ -495,9 +496,10 @@ int nfc_llcp_send_cc(struct nfc_llcp_sock *sock)

		skb_queue_tail(&local->tx_queue, skb);

		return 0;
		err = 0;

		error_tlv:
		if (err)
		pr_err("error %d\n", err);

		kfree(miux_tlv);