Commit 2464e909 authored Apr 19, 2016 by Abhijeet Dharmapurikar Committed by David Collins Jan 13, 2017

spmi: pmic_arb: use appropriate flow handler



The current code uses handle_level_irq flow handler even if the trigger
type of the interrupt is edge. This can lead to missing of an edge
transition that happens when the interrupt is being handled. The level
flow handler masks the interrupt while it is being handled, so if an edge
transition happens at that time, that edge is lost.

Use an edge flow handler for edge type interrupts which ensures that the
interrupt stays enabled while being handled - at least until it triggers
at which point the flow handler sets the IRQF_PENDING flag and only then
masks the interrupt. That IRQF_PENDING state indicates an edge transition
happened while the interrupt was being handled and the handler is called
again.

CRs-Fixed: 1001770
Change-Id: Id2554c9e6ed79188fa1b64728be464bda45f07ec
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>

parent 9c10f8f3

drivers/spmi/spmi-pmic-arb.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -629,6 +629,12 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)
		}

		qpnpint_spmi_write(d, QPNPINT_REG_SET_TYPE, &type, sizeof(type));

		if (flow_type & IRQ_TYPE_EDGE_BOTH)
		irq_set_handler_locked(d, handle_edge_irq);
		else
		irq_set_handler_locked(d, handle_level_irq);

		return 0;
		}