Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 230b5786 authored by Johannes Berg's avatar Johannes Berg Committed by Greg Kroah-Hartman
Browse files

cfg80211: check for set_wiphy_params 



commit 24953de0a5e31dcca7e82c8a3c79abc2dfe8fb6e upstream.

Check if set_wiphy_params is assigned and return an error if not,
some drivers (e.g. virt_wifi where syzbot reported it) don't have
it.

Reported-by: default avatar <syzbot+e8a797964a4180eb57d5@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+34b582cf32c1db008f8e@syzkaller.appspotmail.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Link: https://lore.kernel.org/r/20200113125358.ac07f276efff.Ibd85ee1b12e47b9efb00a2adc5cd3fac50da791a@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c136d25c

net/wireless/rdev-ops.h

+4 −0
Original line number Diff line number Diff line
@@ -525,6 +525,10 @@ static inline int 
rdev_set_wiphy_params(struct cfg80211_registered_device *rdev, u32 changed)

{

	int ret;



	if (!rdev->ops->set_wiphy_params)

		return -EOPNOTSUPP;



	trace_rdev_set_wiphy_params(&rdev->wiphy, changed);

	ret = rdev->ops->set_wiphy_params(&rdev->wiphy, changed);

	trace_rdev_return_int(&rdev->wiphy, ret);