Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22e9f5a6 authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Martin K. Petersen
Browse files

aacraid: use kmemdup 



Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Reviewed-by: default avatarRaghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 014e8ba7

drivers/scsi/aacraid/commctrl.c

+3 −4
Original line number Diff line number Diff line
@@ -635,15 +635,14 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) 
			}

		} else {

			struct user_sgmap* usg;

			usg = kmalloc(actual_fibsize - sizeof(struct aac_srb)

			usg = kmemdup(upsg,

				      actual_fibsize - sizeof(struct aac_srb)

				      + sizeof(struct sgmap), GFP_KERNEL);

			if (!usg) {

				dprintk((KERN_DEBUG"aacraid: Allocation error in Raw SRB command\n"));

				rcode = -ENOMEM;

				goto cleanup;

			}

			memcpy (usg, upsg, actual_fibsize - sizeof(struct aac_srb)

			  + sizeof(struct sgmap));

			actual_fibsize = actual_fibsize64;



			for (i = 0; i < usg->count; i++) {