Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2212e680 authored by Charles Keepax's avatar Charles Keepax Committed by Lee Jones
Browse files

mfd: arizona: Mark missing AOD registers as volatile 



This registers ARIZONA_AOD_WKUP_AND_TRIG and ARIZONA_AOD_IRQ_RAW_STATUS
contain interrupt status bits and thus should be volatile. They are
correctly marked on wm5102 but not on wm5110, this patch changes this.
Furthermore volatile registers don't need defaults so remove those.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 91c73935

drivers/mfd/wm5102-tables.c

+0 −1
Original line number Diff line number Diff line
@@ -903,7 +903,6 @@ static const struct reg_default wm5102_reg_default[] = { 
	{ 0x00000D1B, 0xFFFF },   /* R3355  - IRQ2 Status 4 Mask */ 

	{ 0x00000D1C, 0xFFFF },   /* R3356  - IRQ2 Status 5 Mask */ 

	{ 0x00000D1F, 0x0000 },   /* R3359  - IRQ2 Control */ 

	{ 0x00000D50, 0x0000 },   /* R3408  - AOD wkup and trig */

	{ 0x00000D53, 0xFFFF },   /* R3411  - AOD IRQ Mask IRQ1 */ 

	{ 0x00000D54, 0xFFFF },   /* R3412  - AOD IRQ Mask IRQ2 */ 

	{ 0x00000D56, 0x0000 },   /* R3414  - Jack detect debounce */

drivers/mfd/wm5110-tables.c

+2 −1
Original line number Diff line number Diff line
@@ -1204,7 +1204,6 @@ static const struct reg_default wm5110_reg_default[] = { 
	{ 0x00000D1B, 0xFFFF },    /* R3355  - IRQ2 Status 4 Mask */

	{ 0x00000D1C, 0xFFFF },    /* R3356  - IRQ2 Status 5 Mask */

	{ 0x00000D1F, 0x0000 },    /* R3359  - IRQ2 Control */

	{ 0x00000D50, 0x0000 },    /* R3408  - AOD wkup and trig */

	{ 0x00000D53, 0xFFFF },    /* R3411  - AOD IRQ Mask IRQ1 */

	{ 0x00000D54, 0xFFFF },    /* R3412  - AOD IRQ Mask IRQ2 */

	{ 0x00000D56, 0x0000 },    /* R3414  - Jack detect debounce */
@@ -2363,8 +2362,10 @@ static bool wm5110_volatile_register(struct device *dev, unsigned int reg) 
	case ARIZONA_INTERRUPT_RAW_STATUS_7:

	case ARIZONA_INTERRUPT_RAW_STATUS_8:

	case ARIZONA_IRQ_PIN_STATUS:

	case ARIZONA_AOD_WKUP_AND_TRIG:

	case ARIZONA_AOD_IRQ1:

	case ARIZONA_AOD_IRQ2:

	case ARIZONA_AOD_IRQ_RAW_STATUS:

	case ARIZONA_FX_CTRL2:

	case ARIZONA_ASRC_STATUS:

	case ARIZONA_DSP_STATUS: