Commit 21b56ec4 authored Jan 11, 2009 by Alan Cox Committed by Linus Torvalds Jan 12, 2009

neo: Remove a bogus NULL check



Julia Lawall found an un-needed check in the neo driver. Her patch moves
the check to cover the code dereferencing it, however it cannot be NULL
anyway so remove the NULL check instead.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c774bda2

drivers/serial/jsm/jsm_neo.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -577,9 +577,6 @@ static void neo_parse_modem(struct jsm_channel *ch, u8 signals)
		jsm_printk(MSIGS, INFO, &ch->ch_bd->pci_dev,
		"neo_parse_modem: port: %d msignals: %x\n", ch->ch_portnum, msignals);

		if (!ch)
		return;

		/* Scrub off lower bits. They signify delta's, which I don't care about */
		/* Keep DDCD and DDSR though */
		msignals &= 0xf8;