Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2105905b authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

drm: exynos: mark pm functions as __maybe_unused 

commit 7e1751001818209b214b8c3df0b3c91fae250ea2 upstream.

The rework of the exynos DRM clock handling introduced
warnings for configurations that have CONFIG_PM disabled:

drivers/gpu/drm/exynos/exynos_hdmi.c:736:13: error: 'hdmi_clk_disable_gates' defined but not used [-Werror=unused-function]
 static void hdmi_clk_disable_gates(struct hdmi_context *hdata)
             ^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/exynos/exynos_hdmi.c:717:12: error: 'hdmi_clk_enable_gates' defined but not used [-Werror=unused-function]
 static int hdmi_clk_enable_gates(struct hdmi_context *hdata)

The problem is that the PM functions themselves are inside of
an #ifdef, but some functions they call are not.

This patch removes the #ifdef and instead marks the PM functions
as __maybe_unused, which is a more reliable way to get it right.

Link: https://patchwork.kernel.org/patch/8436281/


Fixes: 9be7e989 ("drm/exynos/hdmi: clock code re-factoring")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 077463be

drivers/gpu/drm/exynos/exynos_hdmi.c

+2 −4
Original line number Diff line number Diff line
@@ -1939,8 +1939,7 @@ static int hdmi_remove(struct platform_device *pdev) 
	return 0;

}



#ifdef CONFIG_PM

static int exynos_hdmi_suspend(struct device *dev)

static int __maybe_unused exynos_hdmi_suspend(struct device *dev)

{

	struct hdmi_context *hdata = dev_get_drvdata(dev);
@@ -1949,7 +1948,7 @@ static int exynos_hdmi_suspend(struct device *dev) 
	return 0;

}



static int exynos_hdmi_resume(struct device *dev)

static int __maybe_unused exynos_hdmi_resume(struct device *dev)

{

	struct hdmi_context *hdata = dev_get_drvdata(dev);

	int ret;
@@ -1960,7 +1959,6 @@ static int exynos_hdmi_resume(struct device *dev) 


	return 0;

}

#endif



static const struct dev_pm_ops exynos_hdmi_pm_ops = {

	SET_RUNTIME_PM_OPS(exynos_hdmi_suspend, exynos_hdmi_resume, NULL)