Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 204f69ba authored by Wei Yongjun's avatar Wei Yongjun Committed by Doug Ledford
Browse files

IB/hns: Fix return value check in hns_roce_get_cfg() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: default avatarWei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 66a9bae6

drivers/infiniband/hw/hns/hns_roce_main.c

+2 −2
Original line number Diff line number Diff line
@@ -715,8 +715,8 @@ static int hns_roce_get_cfg(struct hns_roce_dev *hr_dev) 


	res = platform_get_resource(hr_dev->pdev, IORESOURCE_MEM, 0);

	hr_dev->reg_base = devm_ioremap_resource(dev, res);

	if (!hr_dev->reg_base)

		return -ENOMEM;

	if (IS_ERR(hr_dev->reg_base))

		return PTR_ERR(hr_dev->reg_base);



	for (i = 0; i < HNS_ROCE_MAX_PORTS; i++) {

		net_node = of_parse_phandle(np, "eth-handle", i);