Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f95f8c9 authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: sbp2: remove redundant check for bidi command 



[Bart van Asche:]  SCSI core never sets cmd->sc_data_direction to
DMA_BIDIRECTIONAL; scsi_bidi_cmnd(cmd) should be used instead to
test for a bidirectional command.

[Christoph Hellwig:]  Bidirectional commands won't ever be queued
anyway, unless a LLD or transport driver sets QUEUE_FLAG_BIDI.

So, simply remove the respective queuecommand check in the SBP-2
transport driver.

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent b625a825

drivers/firewire/sbp2.c

+0 −11
Original line number Diff line number Diff line
@@ -1463,17 +1463,6 @@ static int sbp2_scsi_queuecommand(struct Scsi_Host *shost, 
	struct sbp2_command_orb *orb;

	int generation, retval = SCSI_MLQUEUE_HOST_BUSY;



	/*

	 * Bidirectional commands are not yet implemented, and unknown

	 * transfer direction not handled.

	 */

	if (cmd->sc_data_direction == DMA_BIDIRECTIONAL) {

		dev_err(lu_dev(lu), "cannot handle bidirectional command\n");

		cmd->result = DID_ERROR << 16;

		cmd->scsi_done(cmd);

		return 0;

	}



	orb = kzalloc(sizeof(*orb), GFP_ATOMIC);

	if (orb == NULL)

		return SCSI_MLQUEUE_HOST_BUSY;