Commit 1f5a5128 authored Mar 16, 2017 by Johan Hovold Committed by Greg Kroah-Hartman Mar 30, 2017

Input: ims-pcu - validate number of endpoints before using them



commit 1916d319271664241b7aa0cd2b05e32bdb310ce9 upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack control-interface endpoints.

Fixes: 628329d5 ("Input: add IMS Passenger Control Unit driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0afac79f

drivers/input/misc/ims-pcu.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1667,6 +1667,10 @@ static int ims_pcu_parse_cdc_data(struct usb_interface intf, struct ims_pcu pc
		return -EINVAL;

		alt = pcu->ctrl_intf->cur_altsetting;

		if (alt->desc.bNumEndpoints < 1)
		return -ENODEV;

		pcu->ep_ctrl = &alt->endpoint[0].desc;
		pcu->max_ctrl_size = usb_endpoint_maxp(pcu->ep_ctrl);