Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e6e0974 authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Peter Huewe
Browse files

tpm atmel: Call request_region with the correct base 



Commit e0dd03ca ("tpm: return chip from
tpm_register_hardware") changed the code path here so that
ateml_get_base_addr no longer directly altered the tpm_vendor_specific
structure, and instead placed the base address on the stack.

The commit missed updating the request_region call, which would have
resulted in request_region being called with 0 as the base address.

I don't know if request_region(0, ..) will fail, if so the
driver has been broken since 2006 and we should remove it
from the tree as it has no users.

Signed-off-by: default avatarJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: default avatarJoel Schopp <jschopp@linux.vnet.ibm.com>
Reviewed-by: default avatarPeter Huewe <peterhuewe@gmx.de>
Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
parent 37ab0341

drivers/char/tpm/tpm_atmel.c

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ static int __init init_atmel(void) 


	have_region =

	    (atmel_request_region

	     (tpm_atmel.base, region_size, "tpm_atmel0") == NULL) ? 0 : 1;

	     (base, region_size, "tpm_atmel0") == NULL) ? 0 : 1;



	pdev = platform_device_register_simple("tpm_atmel", -1, NULL, 0);

	if (IS_ERR(pdev)) {