Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e6b5033 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Greg Kroah-Hartman
Browse files

iio: magnetometer: ak8974: remove incorrect __exit markups 



commit 3ff861f59f6c1f5bf2bc03d2cd36ac3f992cbc06 upstream.

Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9808ff15

drivers/iio/magnetometer/ak8974.c

+2 −2
Original line number Diff line number Diff line
@@ -767,7 +767,7 @@ static int ak8974_probe(struct i2c_client *i2c, 
	return ret;

}



static int __exit ak8974_remove(struct i2c_client *i2c)

static int ak8974_remove(struct i2c_client *i2c)

{

	struct iio_dev *indio_dev = i2c_get_clientdata(i2c);

	struct ak8974 *ak8974 = iio_priv(indio_dev);
@@ -849,7 +849,7 @@ static struct i2c_driver ak8974_driver = { 
		.of_match_table = of_match_ptr(ak8974_of_match),

	},

	.probe	  = ak8974_probe,

	.remove	  = __exit_p(ak8974_remove),

	.remove	  = ak8974_remove,

	.id_table = ak8974_id,

};

module_i2c_driver(ak8974_driver);