Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e456a12 authored by David Howells's avatar David Howells Committed by Linus Torvalds
Browse files

KEYS: request_key() should return -ENOKEY if the constructed key is negative 



request_key() should return -ENOKEY if the key it constructs has been
negatively instantiated.

Without this, request_key() can return an unusable key to its caller,
and if the caller then does key_validate() that won't catch the problem.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fc1caf6e

security/keys/request_key.c

+2 −0
Original line number Diff line number Diff line
@@ -537,6 +537,8 @@ int wait_for_key_construction(struct key *key, bool intr) 
			  intr ? TASK_INTERRUPTIBLE : TASK_UNINTERRUPTIBLE);

	if (ret < 0)

		return ret;

	if (test_bit(KEY_FLAG_NEGATIVE, &key->flags))

		return -ENOKEY;

	return key_validate(key);

}

EXPORT_SYMBOL(wait_for_key_construction);