Commit 1de86951 authored Jan 21, 2017 by Maciej S. Szmigiero Committed by Greg Kroah-Hartman Mar 12, 2017

w1: don't leak refcount on slave attach failure in w1_attach_slave_device()



commit d2ce4ea1a0b0162e5d2d7e7942ab6f5cc2063d5a upstream.

Near the beginning of w1_attach_slave_device() we increment a w1 master
reference count.
Later, when we are going to exit this function without actually attaching
a slave device (due to failure of __w1_attach_slave_device()) we need to
decrement this reference count back.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Fixes: 9fcbbac5 ("w1: process w1 netlink commands in w1_process thread")
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7afc0ee6

drivers/w1/w1.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -763,6 +763,7 @@ int w1_attach_slave_device(struct w1_master dev, struct w1_reg_num rn)
		dev_err(&dev->dev, "%s: Attaching %s failed.\n", __func__,
		sl->name);
		w1_family_put(sl->family);
		atomic_dec(&sl->master->refcnt);
		kfree(sl);
		return err;
		}