Commit 1d5167b7 authored Aug 01, 2014 by Pawel Moll Committed by Tomi Valkeinen Aug 04, 2014

video: ARM CLCD: Fix DT-related build problems



This patch fixes the following error when !CONFIG_OF:

drivers/video/fbdev/amba-clcd.c:800:54: warning: ‘struct amba_dev’ declared inside parameter list [enabled by default]
 static struct clcd_board *clcdfb_of_get_board(struct amba_dev *dev)
                                                      ^
and adds a missing Kconfig select causing this
when CONFIG_OF && !CONFIG_FB_MODE_HELPERS:

drivers/video/fbdev/amba-clcd.c:567: undefined reference to `fb_videomode_from_videomode'

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent d7aa64c3

drivers/video/fbdev/Kconfig

+1 −0

Original line number	Diff line number	Diff line
		@@ -280,6 +280,7 @@ config FB_ARMCLCD
		select FB_CFB_FILLRECT
		select FB_CFB_COPYAREA
		select FB_CFB_IMAGEBLIT
		select FB_MODE_HELPERS if OF
		select VIDEOMODE_HELPERS if OF
		help
		This framebuffer device driver is for the ARM PrimeCell PL110

drivers/video/fbdev/amba-clcd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -797,7 +797,7 @@ static struct clcd_board clcdfb_of_get_board(struct amba_device dev)
		return board;
		}
		#else
		static struct clcd_board clcdfb_of_get_board(struct amba_dev dev)
		static struct clcd_board clcdfb_of_get_board(struct amba_device dev)
		{
		return NULL;
		}