Commit 1cafdac8 authored Oct 12, 2017 by weiping zhang Committed by Greg Kroah-Hartman Dec 20, 2017

scsi: sd: change manage_start_stop to bool in sysfs interface




[ Upstream commit 623401ee33e42cee64d333877892be8db02951eb ]

/sys/class/scsi_disk/0:2:0:0/manage_start_stop can be changed to 0
unexpectly by writing an invalid string.

Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8315bcf8

drivers/scsi/sd.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -234,11 +234,15 @@ manage_start_stop_store(struct device dev, struct device_attribute attr,
		{
		struct scsi_disk *sdkp = to_scsi_disk(dev);
		struct scsi_device *sdp = sdkp->device;
		bool v;

		if (!capable(CAP_SYS_ADMIN))
		return -EACCES;

		sdp->manage_start_stop = simple_strtoul(buf, NULL, 10);
		if (kstrtobool(buf, &v))
		return -EINVAL;

		sdp->manage_start_stop = v;

		return count;
		}