Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c9e919f authored by Jeff Garzik's avatar Jeff Garzik Committed by Ralf Baechle
Browse files

[MIPS] msp_hwbutton.c: minor irq handler cleanups 



- remove always-true test

- neaten request_irq() indentation

This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.

Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent a6406304

arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c

+1 −4
Original line number Diff line number Diff line
@@ -126,9 +126,6 @@ static irqreturn_t hwbutton_handler(int irq, void *data) 
	struct hwbutton_interrupt *hirq = data;

	unsigned long cic_ext = *CIC_EXT_CFG_REG;



	if (irq != hirq->irq)

		return IRQ_NONE;



	if (CIC_EXT_IS_ACTIVE_HI(cic_ext, hirq->eirq)) {

		/* Interrupt: pin is now HI */

		CIC_EXT_SET_ACTIVE_LO(cic_ext, hirq->eirq);
@@ -164,7 +161,7 @@ static int msp_hwbutton_register(struct hwbutton_interrupt *hirq) 
	*CIC_EXT_CFG_REG = cic_ext;



	return request_irq(hirq->irq, hwbutton_handler, IRQF_DISABLED,

				hirq->name, (void *)hirq);

			   hirq->name, hirq);

}



static int __init msp_hwbutton_setup(void)