Commit 1bb850a1 authored Feb 23, 2016 by Dan Bogdan Nechita Committed by Greg Kroah-Hartman Mar 01, 2016

misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes

Currently writing the attributes with "echo" will result in comparing:
"enabled\n" with "enabled\0" and attribute is always set to false.

Use the sysfs_streq() instead because it treats both NUL and
new-line-then-NUL as equivalent string terminations.

Signed-off-by: Dan Bogdan Nechita <dan.bogdan.nechita@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f3df53e4

drivers/misc/ad525x_dpot.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -452,7 +452,7 @@ static ssize_t sysfs_set_reg(struct device *dev,
	int err;		int err;

	if (reg & DPOT_ADDR_OTP_EN) {		if (reg & DPOT_ADDR_OTP_EN) {
	if (!strncmp(buf, "enabled", sizeof("enabled")))		if (sysfs_streq(buf, "enabled"))
	set_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);		set_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);
	else		else
	clear_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);		clear_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);