Commit 1bb6e0cc authored Nov 28, 2018 by Pan Bian Committed by Greg Kroah-Hartman Dec 17, 2018

net: hisilicon: remove unexpected free_netdev



[ Upstream commit c758940158bf29fe14e9d0f89d5848f227b48134 ]

The net device ndev is freed via free_netdev when failing to register
the device. The control flow then jumps to the error handling code
block. ndev is used and freed again. Resulting in a use-after-free bug.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 992963c6

drivers/net/ethernet/hisilicon/hip04_eth.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -922,10 +922,8 @@ static int hip04_mac_probe(struct platform_device *pdev)
		}

		ret = register_netdev(ndev);
		if (ret) {
		free_netdev(ndev);
		if (ret)
		goto alloc_fail;
		}

		return 0;