Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b7acf0c authored by Thomas Meyer's avatar Thomas Meyer Committed by Mauro Carvalho Chehab
Browse files

[media] xc4000: Use kcalloc instead of kzalloc to allocate array 

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 9884d7be

drivers/media/common/tuners/tuner-xc2028.c

+1 −1
Original line number Diff line number Diff line
@@ -311,7 +311,7 @@ static int load_all_firmwares(struct dvb_frontend *fe) 
		   n_array, fname, name,

		   priv->firm_version >> 8, priv->firm_version & 0xff);



	priv->firm = kzalloc(sizeof(*priv->firm) * n_array, GFP_KERNEL);

	priv->firm = kcalloc(n_array, sizeof(*priv->firm), GFP_KERNEL);

	if (priv->firm == NULL) {

		tuner_err("Not enough memory to load firmware file.\n");

		rc = -ENOMEM;

drivers/media/common/tuners/xc4000.c

+1 −1
Original line number Diff line number Diff line
@@ -758,7 +758,7 @@ static int xc4000_fwupload(struct dvb_frontend *fe) 
		n_array, fname, name,

		priv->firm_version >> 8, priv->firm_version & 0xff);



	priv->firm = kzalloc(sizeof(*priv->firm) * n_array, GFP_KERNEL);

	priv->firm = kcalloc(n_array, sizeof(*priv->firm), GFP_KERNEL);

	if (priv->firm == NULL) {

		printk(KERN_ERR "Not enough memory to load firmware file.\n");

		rc = -ENOMEM;