Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b764828 authored by Ying Xue's avatar Ying Xue Committed by David S. Miller
Browse files

tipc: introduce tipc_subscrb_create routine 



Introducing a new function makes the purpose of tipc_subscrb_connect_cb
callback routine more clear.

Signed-off-by: default avatarYing Xue <ying.xue@windriver.com>
Reviewed-by: default avatarJon Maloy <jon.maloy@ericson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57f1d186

net/tipc/subscr.c

+17 −13
Original line number Diff line number Diff line
@@ -154,6 +154,22 @@ static void tipc_subscrp_delete(struct tipc_subscription *sub) 
	atomic_dec(&tn->subscription_count);

}



static struct tipc_subscriber *tipc_subscrb_create(int conid)

{

	struct tipc_subscriber *subscriber;



	subscriber = kzalloc(sizeof(*subscriber), GFP_ATOMIC);

	if (!subscriber) {

		pr_warn("Subscriber rejected, no memory\n");

		return NULL;

	}

	INIT_LIST_HEAD(&subscriber->subscrp_list);

	subscriber->conid = conid;

	spin_lock_init(&subscriber->lock);



	return subscriber;

}



static void tipc_subscrb_delete(struct tipc_subscriber *subscriber)

{

	struct tipc_subscription *sub;
@@ -301,19 +317,7 @@ static void tipc_subscrb_rcv_cb(struct net *net, int conid, 
/* Handle one request to establish a new subscriber */

static void *tipc_subscrb_connect_cb(int conid)

{

	struct tipc_subscriber *subscriber;



	/* Create subscriber object */

	subscriber = kzalloc(sizeof(struct tipc_subscriber), GFP_ATOMIC);

	if (subscriber == NULL) {

		pr_warn("Subscriber rejected, no memory\n");

		return NULL;

	}

	INIT_LIST_HEAD(&subscriber->subscrp_list);

	subscriber->conid = conid;

	spin_lock_init(&subscriber->lock);



	return (void *)subscriber;

	return (void *)tipc_subscrb_create(conid);

}



int tipc_topsrv_start(struct net *net)