Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b5680f2 authored by Surabhi Vishnoi's avatar Surabhi Vishnoi
Browse files

wlan: Fix the incorrect logging for PER Roam offload scan 

Firmware do not send any reason in PER roam offload scan request
as in case of Roam offload scan request. Firmware only sends status
as success or failure. Currently PER roam offload scan request callback
assumes that firmware sends reason, this leads to inconsistency in logs.
In PER roam offload scan request success case also, failure log is seen
as reason is always set to 0.

To fix this inconsistency of logs, handle the status sent by firmware
in response to PER Roam offload request differently than Roam offload
scan.

Change-Id: I0dadf351a2dd07e7d8c09e953c9b910387438a04
CRs-Fixed: 2794194
parent 15c65448

CORE/WDA/src/wlan_qct_wda.c

+2 −13
Original line number Diff line number Diff line
@@ -20434,8 +20434,6 @@ void WDA_PERRoamTriggerScanReqCallback(WDI_Status status, void* pUserData) 
void WDA_PERRoamOffloadScanReqCallback(WDI_Status status, void* pUserData)

{

   tWDA_ReqParams *pWdaParams = (tWDA_ReqParams *)pUserData;

   vos_msg_t vosMsg;

   wpt_uint8 reason = 0;















   VOS_TRACE( VOS_MODULE_ID_WDA, VOS_TRACE_LEVEL_INFO,















                                          "<------ %s " ,__func__);









@@ -20451,18 +20449,9 @@ void WDA_PERRoamOffloadScanReqCallback(WDI_Status status, void* pUserData)













       vos_mem_free(pWdaParams->wdaWdiApiMsgParam);





























   vos_mem_free(pWdaParams) ;













   vosMsg.type = eWNI_SME_ROAM_SCAN_OFFLOAD_RSP;













   vosMsg.bodyptr = NULL;















   if (WDI_STATUS_SUCCESS != status)













      reason = 0;

























   vosMsg.bodyval = reason;













   if (VOS_STATUS_SUCCESS !=













       vos_mq_post_message(VOS_MQ_ID_SME, (vos_msg_t*)&vosMsg)) {













      /* free the mem and return */













      VOS_TRACE( VOS_MODULE_ID_WDA, VOS_TRACE_LEVEL_INFO,













                 "%s: Failed to post the rsp to UMAC", __func__);













   }













      VOS_TRACE( VOS_MODULE_ID_WDA, VOS_TRACE_LEVEL_ERROR,













	       "%s: wdi_status %d", __func__, status);





























   return ;















}