Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b3ed70a authored by Felipe Pena's avatar Felipe Pena Committed by Mark Brown
Browse files

ASoC: fsl: Fix memory leak in imx-audmux.c 



When audmux_clk is used and clk_prepare_enable function succeed,
the memory alloc'd to buf variable is leaked

Signed-off-by: default avatarFelipe Pena <felipensp@gmail.com>
Reviewed-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 8e9c4aa4

sound/soc/fsl/imx-audmux.c

+5 −4
Original line number Diff line number Diff line
@@ -66,13 +66,10 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf, 
				size_t count, loff_t *ppos)

{

	ssize_t ret;

	char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);

	char *buf;

	int port = (int)file->private_data;

	u32 pdcr, ptcr;



	if (!buf)

		return -ENOMEM;



	if (audmux_clk) {

		ret = clk_prepare_enable(audmux_clk);

		if (ret)
@@ -85,6 +82,10 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf, 
	if (audmux_clk)

		clk_disable_unprepare(audmux_clk);



	buf = kmalloc(PAGE_SIZE, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;



	ret = snprintf(buf, PAGE_SIZE, "PDCR: %08x\nPTCR: %08x\n",

		       pdcr, ptcr);