Commit 1acd80fb authored May 08, 2016 by Marek Vasut Committed by Marc Kleine-Budde May 09, 2016

can: ifi: Increment TX counters only on real transmission

Only increment the TX counters in the irq handler if a CAN message
was sent. The current code incremented the counters also if the TX
FIFO empty interrupt happened, which is incorrect.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent ca794089

drivers/net/can/ifi_canfd/ifi_canfd.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -522,13 +522,15 @@ static irqreturn_t ifi_canfd_isr(int irq, void *dev_id)
		}

		/* TX IRQ */
		if (isr & tx_irq_mask) {
		if (isr & IFI_CANFD_INTERRUPT_TXFIFO_REMOVE) {
		stats->tx_bytes += can_get_echo_skb(ndev, 0);
		stats->tx_packets++;
		can_led_event(ndev, CAN_LED_EVENT_TX);
		netif_wake_queue(ndev);
		}

		if (isr & tx_irq_mask)
		netif_wake_queue(ndev);

		return IRQ_HANDLED;
		}