Commit 19e59e3f authored Jul 26, 2019 by Takashi Iwai Committed by Greg Kroah-Hartman Oct 05, 2019

ALSA: hda - Show the fatal CORB/RIRB error more clearly



[ Upstream commit dd65f7e19c6961ba6a69f7c925021b7a270cb950 ]

The last fallback of CORB/RIRB communication error recovery is to turn
on the single command mode, and this last resort usually means that
something is really screwed up.  Instead of a normal dev_err(), show
the error more clearly with dev_WARN() with the caller stack trace.

Also, show the bus-reset fallback also as an error, too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2690ec2a

sound/pci/hda/hda_controller.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -866,10 +866,13 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr,
		*/
		if (hbus->allow_bus_reset && !hbus->response_reset && !hbus->in_reset) {
		hbus->response_reset = 1;
		dev_err(chip->card->dev,
		"No response from codec, resetting bus: last cmd=0x%08x\n",
		bus->last_cmd[addr]);
		return -EAGAIN; /* give a chance to retry */
		}

		dev_err(chip->card->dev,
		dev_WARN(chip->card->dev,
		"azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n",
		bus->last_cmd[addr]);
		chip->single_cmd = 1;